Commit 18eec1a7 by Kálmán Viktor

dashboard: fix slider perms

- make the inputs disabled and the slider immoveable if no perms
- take vm acl into consideration when showing the inputs
parent 9ea843e9
......@@ -1124,6 +1124,14 @@ class VmResourcesForm(forms.ModelForm):
'class': "form-control input-tags cpu-priority-input",
}))
def __init__(self, *args, **kwargs):
self.can_edit = kwargs.pop("can_edit", None)
super(VmResourcesForm, self).__init__(*args, **kwargs)
if not self.can_edit:
for name, field in self.fields.items():
field.widget.attrs['disabled'] = "disabled"
class Meta:
model = Instance
fields = ('num_cores', 'priority', 'ram_size', )
......@@ -489,6 +489,10 @@ function addSliderMiscs() {
});
$(".cpu-priority-input").trigger("change");
$(".cpu-count-input, .ram-input").trigger("input");
$(".cpu-priority-slider").simpleSlider("setDisabled", $(".cpu-priority-input").prop("disabled"));
$(".cpu-count-slider").simpleSlider("setDisabled", $(".cpu-count-input").prop("disabled"));
$(".ram-slider").simpleSlider("setDisabled", $(".ram-input").prop("disabled"));
}
......
......@@ -80,7 +80,7 @@ var __slice = [].slice,
});
}
this.dragger.mousedown(function(e) {
if (e.which !== 1) {
if (e.which !== 1 || _this.settings.disabled) {
return;
}
_this.dragging = true;
......@@ -170,6 +170,9 @@ var __slice = [].slice,
if (this.input.data("slider-showscale") != null) {
options.showScale = this.input.data("slider-showscale");
}
if (this.input.data("slider-disabled")) {
options.disabled = this.input.data("slider-disabled");
}
return options;
}
......@@ -207,8 +210,12 @@ var __slice = [].slice,
return this.valueChanged(value, ratio, "setValue");
};
SimpleSlider.prototype.setDisabled = function(value) {
this.settings.disabled = value;
}
SimpleSlider.prototype.trackEvent = function(e) {
if (e.which !== 1) {
if (e.which !== 1 || this.settings.disabled) {
return;
}
this.domDrag(e.pageX, e.pageY, true);
......@@ -374,7 +381,7 @@ var __slice = [].slice,
simpleSlider: function() {
var params, publicMethods, settingsOrMethod;
settingsOrMethod = arguments[0], params = 2 <= arguments.length ? __slice.call(arguments, 1) : [];
publicMethods = ["setRatio", "setValue"];
publicMethods = ["setRatio", "setValue", "setDisabled", ];
return $(this).each(function() {
var obj, settings;
if (settingsOrMethod && __indexOf.call(publicMethods, settingsOrMethod) >= 0) {
......
......@@ -6,7 +6,7 @@
{% csrf_token %}
{% include "dashboard/_resources-sliders.html" with field_priority=resources_form.priority field_num_cores=resources_form.num_cores field_ram_size=resources_form.ram_size %}
{% if can_change_resources %}
{% if op.resources_change %}
<button type="submit" class="btn btn-success btn-sm change-resources-button"
id="vm-details-resources-save" data-vm="{{ instance.pk }}"
{% if op.resources_change.disabled %}disabled{% endif %}>
......
......@@ -295,7 +295,8 @@ class VmDetailView(CheckedDetailView):
def get_context_data(self, **kwargs):
context = super(VmDetailView, self).get_context_data(**kwargs)
instance = context['instance']
ops = get_operations(instance, self.request.user)
user = self.request.user
ops = get_operations(instance, user)
context.update({
'graphite_enabled': settings.GRAPHITE_URL is not None,
'vnc_url': reverse_lazy("dashboard.views.detail-vnc",
......@@ -305,7 +306,7 @@ class VmDetailView(CheckedDetailView):
})
# activity data
activities = instance.get_merged_activities(self.request.user)
activities = instance.get_merged_activities(user)
show_show_all = len(activities) > 10
activities = activities[:10]
context['activities'] = activities
......@@ -327,7 +328,11 @@ class VmDetailView(CheckedDetailView):
context['ipv6_port'] = instance.get_connect_port(use_ipv6=True)
# resources forms
context['resources_form'] = VmResourcesForm(instance=instance)
can_edit = (
instance in Instance.get_objects_with_level("owner", user)
and self.request.user.has_perm("vm.change_resources"))
context['resources_form'] = VmResourcesForm(
can_edit=can_edit, instance=instance)
if self.request.user.is_superuser:
context['traits_form'] = TraitsForm(instance=instance)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment