dashboard: fix lease delete tests

circle/dashboard/tests/test_views.py

@@ -299,7 +299,7 @@ class VmDetailTest(LoginMixin, TestCase):
         leases = Lease.objects.count()
         leases = Lease.objects.count()
         response = c.post("/dashboard/lease/delete/1/")
         response = c.post("/dashboard/lease/delete/1/")
         # redirect to the login page
         # redirect to the login page
-        self.assertEqual(response.status_code, 302)
+        self.assertEqual(response.status_code, 403)
         self.assertEqual(leases, Lease.objects.count())
         self.assertEqual(leases, Lease.objects.count())
 
 
     def test_notification_read(self):
     def test_notification_read(self):

circle/dashboard/views/template.py

@@ -471,10 +471,9 @@ class LeaseDelete(LoginRequiredMixin, DeleteView):
     def delete(self, request, *args, **kwargs):
     def delete(self, request, *args, **kwargs):
         object = self.get_object()
         object = self.get_object()
 
 
-        # if there are still templates with this lease
-        # or the user is not owner
-        if (object.instancetemplate_set.count() > 0
-                or not object.has_level(request.user, "owner")):
+        if not object.has_level(request.user, "owner"):
+            raise PermissionDenied()
+        if object.instancetemplate_set.count() > 0:
             raise SuspiciousOperation()
             raise SuspiciousOperation()
 
 
         object.delete()
         object.delete()