dashboard: handle SchedulerError in MigrateView

circle/dashboard/templates/dashboard/_vm-migrate.html

@@ -13,7 +13,7 @@ Choose a compute node to migrate {{obj}} to.
 
 
 {% block formfields %}
 {% block formfields %}
   <ul id="vm-migrate-node-list" class="list-unstyled">
   <ul id="vm-migrate-node-list" class="list-unstyled">
-  {% with current=object.node.pk selected=object.select_node.pk %}
+  {% with current=object.node.pk %}
     {% for n in nodes %}
     {% for n in nodes %}
       <li class="panel panel-default"><div class="panel-body">
       <li class="panel panel-default"><div class="panel-body">
         <label for="migrate-to-{{n.pk}}">
         <label for="migrate-to-{{n.pk}}">
@@ -21,11 +21,11 @@ Choose a compute node to migrate {{obj}} to.
           <div class="label label-primary"><i class="fa {{n.get_status_icon}}"></i>
           <div class="label label-primary"><i class="fa {{n.get_status_icon}}"></i>
               {{n.get_status_display}}</div>
               {{n.get_status_display}}</div>
           {% if current == n.pk %}<div class="label label-info">{% trans "current" %}</div>{% endif %}
           {% if current == n.pk %}<div class="label label-info">{% trans "current" %}</div>{% endif %}
-          {% if selected == n.pk %}<div class="label label-success">{% trans "recommended" %}</div>{% endif %}
+          {% if recommended == n.pk %}<div class="label label-success">{% trans "recommended" %}</div>{% endif %}
         </label>
         </label>
         <input id="migrate-to-{{n.pk}}" type="radio" name="node" value="{{ n.pk }}" style="float: right;"
         <input id="migrate-to-{{n.pk}}" type="radio" name="node" value="{{ n.pk }}" style="float: right;"
         {% if current == n.pk %}disabled="disabled"{% endif %}
         {% if current == n.pk %}disabled="disabled"{% endif %}
-        {% if selected == n.pk %}checked="checked"{% endif %} />
+        {% if recommended == n.pk %}checked="checked"{% endif %} />
         <span class="vm-migrate-node-property">{% trans "CPU load" %}: {{ n.cpu_usage }}</span>
         <span class="vm-migrate-node-property">{% trans "CPU load" %}: {{ n.cpu_usage }}</span>
         <span class="vm-migrate-node-property">{% trans "RAM usage" %}: {{ n.byte_ram_usage|filesize }}/{{ n.ram_size|filesize }}</span>
         <span class="vm-migrate-node-property">{% trans "RAM usage" %}: {{ n.byte_ram_usage|filesize }}/{{ n.ram_size|filesize }}</span>
         <div style="clear: both;"></div>
         <div style="clear: both;"></div>

circle/dashboard/views/vm.py

@@ -45,6 +45,7 @@ from common.models import (
     create_readable, HumanReadableException, fetch_human_exception,
     create_readable, HumanReadableException, fetch_human_exception,
 )
 )
 from firewall.models import Vlan, Host, Rule
 from firewall.models import Vlan, Host, Rule
+from manager.scheduler import SchedulerError
 from storage.models import Disk
 from storage.models import Disk
 from vm.models import (
 from vm.models import (
     Instance, instance_activity, InstanceActivity, Node, Lease,
     Instance, instance_activity, InstanceActivity, Node, Lease,
@@ -420,6 +421,15 @@ class VmMigrateView(VmOperationView):
         ctx = super(VmMigrateView, self).get_context_data(**kwargs)
         ctx = super(VmMigrateView, self).get_context_data(**kwargs)
         ctx['nodes'] = [n for n in Node.objects.filter(enabled=True)
         ctx['nodes'] = [n for n in Node.objects.filter(enabled=True)
                         if n.online]
                         if n.online]
+
+        inst = self.get_object()
+        ctx["recommended"] = None
+        try:
+            if isinstance(inst, Instance):
+                ctx["recommended"] = inst.select_node().pk
+        except SchedulerError:
+            pass
+
         return ctx
         return ctx
 
 
     def post(self, request, extra=None, *args, **kwargs):
     def post(self, request, extra=None, *args, **kwargs):