vm: reenable node if flush fails

circle/vm/models/node.py

@@ -148,10 +148,14 @@ class Node(OperatedMixin, TimeStampedModel):
                 self.enabled = False
                 self.enabled = False
                 self.save()
                 self.save()
 
 
-    def enable(self, user=None):
+    def enable(self, user=None, base_activity=None):
         ''' Enable the node. '''
         ''' Enable the node. '''
         if self.enabled is not True:
         if self.enabled is not True:
-            with node_activity(code_suffix='enable', node=self, user=user):
+            if base_activity:
+                act_ctx = base_activity.sub_activity('enable')
+            else:
+                act_ctx = node_activity('enable', node=self, user=user)
+            with act_ctx:
                 self.enabled = True
                 self.enabled = True
                 self.save()
                 self.save()
             self.get_info(invalidate_cache=True)
             self.get_info(invalidate_cache=True)

circle/vm/operations.py

@@ -594,7 +594,14 @@ class FlushOperation(NodeOperation):
     name = _("flush")
     name = _("flush")
     description = _("Disable node and move all instances to other ones.")
     description = _("Disable node and move all instances to other ones.")
 
 
+    def on_abort(self, activity, error):
+        from manager.scheduler import TraitsUnsatisfiableException
+        if isinstance(error, TraitsUnsatisfiableException):
+            if self.node_enabled:
+                self.node.enable(activity.user, activity)
+
     def _operation(self, activity, user):
     def _operation(self, activity, user):
+        self.node_enabled = self.node.enabled
         self.node.disable(user, activity)
         self.node.disable(user, activity)
         for i in self.node.instance_set.all():
         for i in self.node.instance_set.all():
             with activity.sub_activity('migrate_instance_%d' % i.pk):
             with activity.sub_activity('migrate_instance_%d' % i.pk):