vm: operation for adding a new network interface to a VM

circle/dashboard/views.py

@@ -404,8 +404,7 @@ class VmDetailView(CheckedDetailView):
         if not vlan.has_level(request.user, 'user'):
             raise PermissionDenied()
         try:
-            Interface.create(vlan=vlan, instance=self.object,
-                             managed=vlan.managed, owner=request.user)
+            self.object.add_interface(vlan=vlan, user=request.user)
             messages.success(request, _("Successfully added new interface!"))
         except Exception, e:
             error = u' '.join(e.messages)

circle/vm/operations.py

@@ -10,7 +10,8 @@ from celery.exceptions import TimeLimitExceeded
 from common.operations import Operation, register_operation
 from .tasks.local_tasks import async_instance_operation, async_node_operation
 from .models import (
-    Instance, InstanceActivity, InstanceTemplate, Node, NodeActivity,
+    Instance, InstanceActivity, InstanceTemplate, Interface, Node,
+    NodeActivity,
 )
 
 
@@ -58,6 +59,29 @@ def register_instance_operation(op_cls, op_id=None):
     return register_operation(Instance, op_cls, op_id)
 
 
+class AddInterfaceOperation(InstanceOperation):
+    activity_code_suffix = 'add_interface'
+    id = 'add_interface'
+    name = _("add interface")
+    description = _("Add a new network interface for the specified VLAN to "
+                    "the VM.")
+
+    def _operation(self, activity, user, system, vlan, managed=None):
+        if managed is None:
+            managed = vlan.managed
+
+        net = Interface.create(base_activity=activity, instance=self.instance,
+                               managed=managed, owner=user, vlan=vlan)
+
+        if self.instance.is_running:
+            net.deploy()
+
+        return net
+
+
+register_instance_operation(AddInterfaceOperation)
+
+
 class DeployOperation(InstanceOperation):
     activity_code_suffix = 'deploy'
     id = 'deploy'