Debug messages and exception handling added.

src/client.py

@@ -21,13 +21,31 @@ class Client:
 		hostname.reverse()
 		self.name = "circle." + ".".join(hostname)
 		self.server_address = str(os.getenv("GRAPHITE_SERVER_ADDRESS"))
-        self.server_port = int(os.getenv("GRAPHITE_SERVER_PORT").__str__())
+		self.server_port = int(os.getenv("GRAPHITE_SERVER_PORT"))
 		self.debugMode = config["debugMode"]
 		self.amqp_user = str(os.getenv("GRAPHITE_AMQP_USER"))
 		self.amqp_pass = str(os.getenv("GRAPHITE_AMQP_PASSWORD"))
 		self.amqp_queue = str(os.getenv("GRAPHITE_AMQP_QUEUE"))
 		self.amqp_vhost = str(os.getenv("GRAPHITE_AMQP_VHOST"))
 		self.beat = 1
+		if self.server_address is None:
+			print("GRAPHITE_SERVER_ADDRESS cannot be found in environmental "
+			      "variables"
+			)
+		if self.server_port is None:
+			print("GRAPHITE_SERVER_PORT cannot be found in environmental "
+			      "variables. (AMQP standard is: 5672"
+			)
+		if self.amqp_user is None or self.amqp_user is None:
+			print("GRAPHITE_AMQP_USER or GRAPHITE_AMQP_PASSWORD cannot be "
+			      "found in environmental variables. (AMQP standard is: "
+			      "guest-guest)"
+			)
+		if self.amqp_queue is None or self.amqp_vhost is None:
+			print("GRAPHITE_AMQP_QUEUE or GRAPHITE_AMQP_VHOST cannot be "
+			      "found in environmental variables."
+			)
+
 
 	def __connect(self):
 		"""
@@ -43,22 +61,36 @@ class Client:
 			self.connection = pika.BlockingConnection(params)
 			self.channel = self.connection.channel()
 			return True
-        except:
-            raise
+		except RuntimeError:
+			print ("[ERROR] Cannot connect to the server. "
+			       "Parameters could be wrong."
+			)
 
 	def __disconnect(self):
 		"""
 		Break up the connection to the graphite server.
 		"""
+		try:
 			self.channel.close()
 			self.connection.close()
+		except RuntimeError:
+			print("[ERROR] An error has occured while disconnecting from the "
+			      "server."
+			)
 
 	def __send(self, message):
 		"""
 		Send the message given in the parameters.
 		"""
+		try:
 			self.channel.basic_publish(exchange=self.amqp_queue,
 		                               routing_key='', body="\n".join(message))
+			return True
+		except:
+			print("[ERROR] An error has occured while sending metrics to the "
+			      "server."
+			)
+			return False
 
 	def __collectFromNode(self, metricCollectors):
 		"""
@@ -88,7 +120,8 @@ class Client:
 				          if cmd_param == "-m"]
 				running_vms.append([entry.as_dict()["cmdline"][search[0] + 1],
 				                    entry.pid,
-                                    int(entry.as_dict()["cmdline"][memory[0] + 1])])
+				                    int(entry.as_dict()["cmdline"][
+					                    memory[0] + 1])])
 		for vm in running_vms:
 			vm_proc = psutil.Process(vm[1])
 			metrics.append((self.name + "." + "kvm." +
@@ -118,10 +151,11 @@ class Client:
 		modul to work properly.
 		"""
 		if self.__connect() is False:
-            print("An error has occured while connecting to the server on %s"
+			print("[ERROR] An error has occured while connecting to the "
+			      "server on %s."
 			      % (self.server_address + ":" + str(self.server_port)))
 		else:
-            print("Connection established to %s on port %s. \
+			print("[SUCCESS] Connection established to %s on port %s. \
                   Clientname: %s"
 			      % (self.server_address, self.server_port,
 			         self.name))
@@ -129,15 +163,18 @@ class Client:
 			maxFrequency = self.getMaxFrequency(metricCollectors)
 			while True:
 				metrics = self.__collectFromNode(metricCollectors)
-                metrics.append(self.__collectFromVMs())
-                if self.debugMode == "True":
-                    print(metrics)
-                self.__send(metrics)
+				vmMetrics = self.__collectFromVMs()
+				if len(vmMetrics) is not 0:
+					metrics.append(vmMetrics)
+				if self.debugMode == "True" and len(metrics) is not 0:
+					print("[*" + self.beat + "] " + metrics)
+				if self.__send(metrics) is False:
+					raise RuntimeError
 				time.sleep(1)
 				self.beat = self.beat + 1
 				if ((self.beat % (maxFrequency + 1)) is 0):
 					self.beat = 1
 		except KeyboardInterrupt:
-            print("Reporting has stopped by the user. Exiting...")
+			print("[x] Reporting has stopped by the user. Exiting...")
 		finally:
 			self.__disconnect()