Check template instance limit of user when creating VM

circle/dashboard/views/vm.py

@@ -1166,24 +1166,28 @@ class VmCreate(LoginRequiredMixin, TemplateView):
 
         # limit chekcs
         try:
-            limit = user.profile.instance_limit
+            instance_limit = user.profile.instance_limit
+            template_instance_limit = user.profile.template_instance_limit
         except Exception as e:
             logger.debug('No profile or instance limit: %s', e)
         else:
             try:
                 amount = int(request.POST.get("amount", 1))
             except:
-                amount = limit  # TODO this should definitely use a Form
-            current = Instance.active.filter(owner=user).count()
-            logger.debug('current use: %d, limit: %d', current, limit)
-            if current + amount > limit:
-                messages.error(request,
-                               _('Instance limit (%d) exceeded.') % limit)
-                if request.is_ajax():
-                    return HttpResponse(json.dumps({'redirect': '/'}),
-                                        content_type="application/json")
-                else:
-                    return redirect('/')
+                # TODO this should definitely use a Form
+                amount = instance_limit
+            instances = Instance.active.filter(owner=user).count()
+            template_instances = template.get_user_instances(user).count()
+
+            logger.debug('current instance use: %d, limit: %d',
+                         instances, instance_limit)
+            logger.debug('current template instance use: %d, limit: %d',
+                         template_instances, template_instance_limit)
+
+            if instances + amount > instance_limit:
+                return self._limit_exceeded(instance_limit, request)
+            if template_instances + amount > template_instance_limit:
+                return self._limit_exceeded(template_instance_limit, request)
 
         create_func = (self.__create_normal if
                        request.POST.get("customized") is None else
@@ -1191,6 +1195,16 @@ class VmCreate(LoginRequiredMixin, TemplateView):
 
         return create_func(request, template, *args, **kwargs)
 
+    def _limit_exceeded(self, limit, request):
+        messages.error(request,
+                       _('Instance limit (%d) exceeded.')
+                       % limit)
+        if request.is_ajax():
+            return HttpResponse(json.dumps({'redirect': '/'}),
+                                content_type="application/json")
+        else:
+            return redirect('/')
+
 
 @require_GET
 def get_vm_screenshot(request, pk):