school: error msg for sp login wo/ email, fixes #129

school/tests.py

@@ -215,4 +215,4 @@ class ViewTestCase(TestCase):
     def test_login_without_email(self):
     def test_login_without_email(self):
         del self.http_headers['email']
         del self.http_headers['email']
         resp = self.client.get('/login/', follow=True, **self.http_headers)
         resp = self.client.get('/login/', follow=True, **self.http_headers)
-        print resp.status_code
+        self.assertEqual(403, resp.status_code)

school/views.py

 from datetime import datetime
 from datetime import datetime
-from django.core.exceptions import ValidationError
+from django.core.exceptions import PermissionDenied, ValidationError
 from django.conf import settings
 from django.conf import settings
 from django.contrib.auth.decorators import login_required
 from django.contrib.auth.decorators import login_required
 from django.contrib.auth.models import User, Group as AGroup
 from django.contrib.auth.models import User, Group as AGroup
@@ -45,7 +45,11 @@ def login(request):
         user.set_unusable_password()
         user.set_unusable_password()
     user.first_name = request.META['givenName']
     user.first_name = request.META['givenName']
     user.last_name = request.META['sn']
     user.last_name = request.META['sn']
-    user.email = request.META['email']
+    try:
+        user.email = request.META['email']
+    except KeyError:
+        messages.error(request, _("The identity provider did not pass the mandatory e-mail data."))
+        raise PermissionDenied()
     user.save()
     user.save()
     p, created = Person.objects.get_or_create(code=user.username)
     p, created = Person.objects.get_or_create(code=user.username)
     p.user_id = user.id
     p.user_id = user.id