Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !113 opened Jul 04, 2014 by Bach Dániel@bachdaniel 
  • Report abuse
Report abuse

Feature Fix Acls

tests 🚧

  • Discussion 3
  • Commits 25
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Bach Dániel
    @bachdaniel started a discussion on commit 9c872372 Jul 04, 2014
    circle/dashboard/views.py
    637 639 is_disk_operation = True
    638 640  
    639 641  
    640 class VmMigrateView(VmOperationView):
    642 class VmMigrateView(SuperuserRequiredMixin, VmOperationView):
    • Bach Dániel @bachdaniel commented Jul 04, 2014
      Owner

      class VmMigrateView(VmOperationView): fixed

      Edited Jul 07, 2014
      ~~class VmMigrateView(VmOperationView):~~ fixed
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Jul 06, 2014
    circle/dashboard/templates/dashboard/vm-detail.html
    135 135 <i class="icon-tasks icon-2x"></i><br>
    136 136 {% trans "Resources" %}</a>
    137 137 </li>
    138 <li{% if not instance.is_console_available %} class="disabled"{% endif %}>
    138 <li{% if not instance.is_console_available or not perms.vm.access_console %} class="disabled"{% endif %}>
    • Őry Máté @orymate commented Jul 06, 2014
      Owner

      Why not hide if user has no permission? What about screenshots? The tab is disabled, but the content itself shouldn't? fixed (24ee0e4c)

      Edited Jul 07, 2014
      ~~Why not hide if user has no permission? What about screenshots? The tab is disabled, but the content itself shouldn't?~~ fixed (24ee0e4c55dfeb61e5d3783b7cf4ebffb003fe24)
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Jul 06, 2014
    circle/vm/operations.py
    593 647 id = 'flush'
    594 648 name = _("flush")
    595 649 description = _("Disable node and move all instances to other ones.")
    650 required_perms = ()
    • Őry Máté @orymate commented Jul 06, 2014
      Owner

      sure? fixed (fa3812a3)

      Edited Jul 07, 2014
      ~~sure?~~ fixed (fa3812a3b3b1d9dd9fcbf65552621c9c2c441af7)
    Please register or sign in to reply
  • Bach Dániel @bachdaniel

    mentioned in issue #202 (closed)

    Sep 04, 2014

    mentioned in issue #202 (closed)

    mentioned in issue #202
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Bach Dániel
Assignee
Bach Dániel @bachdaniel
Assign to
IK migration
Milestone
IK migration
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!113