Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !120 opened Jul 09, 2014 by Dudás Ádám@siliconbrain 
  • Report abuse
Report abuse

Make activities translatable/human readable

Human-readable names and results for activites, notifications and exceptions.

fixes #139 (closed), #187 (closed)

  • Discussion 2
  • Commits 31
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on the diff Jul 10, 2014
    circle/common/models.py
    152 161  
    162 @property
    163 def readable_name(self):
    164 return HumanReadableObject.from_dict(self.readable_name_data)
    165
    166 @readable_name.setter
    167 def set_readable_name(self, value):
    168 self.readable_name_data = None if value is None else value.to_dict()
    169
    170 @property
    171 def result(self):
    172 return HumanReadableObject.from_dict(self.result_data)
    173
    174 @result.setter
    175 def set_result(self, value):
    176 self.result_data = None if value is None else value.to_dict()
    • Őry Máté @orymate commented Jul 10, 2014
      Owner

      don't we need a compatibility interface (with a deprecationwarning) for the case this is called with a string value? fixed

      Edited Jul 17, 2014
      ~~don't we need a compatibility interface (with a deprecationwarning) for the case this is called with a string value?~~ fixed
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Jul 18, 2014
    circle/vm/tasks/local_periodic_tasks.py
    60 61 logger.info("Expired instance %d suspended." % i.pk)
    61 62 try:
    62 63 i.owner.profile.notify(
    63 _('%s suspended') % unicode(i),
    64 'dashboard/notifications/vm-suspended.html',
    65 {'instance': i})
    64 ugettext_noop('%(instance)s suspended'),
    65 ugettext_noop('%s destroyed'), ugettext_noop(
    • Őry Máté @orymate commented Jul 18, 2014
      Owner

      ? fixed

      Edited Jul 18, 2014
      ~~?~~ fixed
    Please register or sign in to reply
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
IK migration
Milestone
IK migration
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!120