Skip to content

CIRCLE / cloud

Go to a project
Merge request !147 opened by  

Featura Mount Store Op

✅

Closes #220 (closed)

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Guba Sándor @gubasandor commented
    Owner

    Umount would be nice 👍

  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    917 921  
    918 922  
    919 923 register_operation(PasswordResetOperation)
    924
    925
    926 class MountStoreOperation(InstanceOperation):
    927 activity_code_suffix = 'mount_store'
    928 id = 'mount_store'
    929 name = _("mount store")
    930 description = _(
    931 "This operation attaches your personal file store. Other users who "
    932 "has acces to this machine can see these files as well."
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    931 "This operation attaches your personal file store. Other users who "
    932 "has acces to this machine can see these files as well."
    933 )
    934 acl_level = "owner"
    935 required_perms = ()
    936
    937 def check_precond(self):
    938 super(MountStoreOperation, self).check_precond()
    939 if self.instance.status not in ["RUNNING"]:
    940 raise self.instance.WrongStateError(self.instance)
    941
    942 try:
    943 latest_deploy = InstanceActivity.objects.filter(
    944 instance=self.instance, activity_code="vm.Instance.deploy"
    945 ).latest("finished").finished
    946 except InstanceActivity.DoesNotExist: # no deploy no agent
    • Őry Máté @orymate commented
      Owner

      this check could be in a separate AgentOperationMixin fixed

      Edited
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    924
    925
    926 class MountStoreOperation(InstanceOperation):
    927 activity_code_suffix = 'mount_store'
    928 id = 'mount_store'
    929 name = _("mount store")
    930 description = _(
    931 "This operation attaches your personal file store. Other users who "
    932 "has acces to this machine can see these files as well."
    933 )
    934 acl_level = "owner"
    935 required_perms = ()
    936
    937 def check_precond(self):
    938 super(MountStoreOperation, self).check_precond()
    939 if self.instance.status not in ["RUNNING"]:
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    Last updated by Őry Máté
    circle/vm/operations.py
    930 description = _(
    931 "This operation attaches your personal file store. Other users who "
    932 "has acces to this machine can see these files as well."
    933 )
    934 acl_level = "owner"
    935 required_perms = ()
    936
    937 def check_precond(self):
    938 super(MountStoreOperation, self).check_precond()
    939 if self.instance.status not in ["RUNNING"]:
    940 raise self.instance.WrongStateError(self.instance)
    941
    942 try:
    943 latest_deploy = InstanceActivity.objects.filter(
    944 instance=self.instance, activity_code="vm.Instance.deploy"
    945 ).latest("finished").finished
    • Őry Máté @orymate commented
      Owner

      ??? This is always true if the instance is in running state, but does not ensure that it is running (failed deploy is also a positive match, or the instance could be stopped meanwhile). fixed

      Edited
    • Kálmán Viktor @kviktor commented
      Owner

      Line 939?

    • Őry Máté @orymate commented
      Owner

      No, the marked line. I didn't catch that the result is used in the next filter until I removed it. The try-except block mislead me, as this shouldn't ever fail if the check above is passing (apart from race conditions).

    Please register or sign in to reply
  • Őry Máté @orymate commented
    Owner

    +1 if works (I don't have store in my devenv)

  • Őry Máté @orymate commented
    Owner

    urlsplit("http://szia.hu:8111").hostname fixed (3f86ff11)

    Edited
  • Bach Dániel
    @bachdaniel started a discussion on commit 3f86ff11
    Please register or sign in to reply
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment