Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !149 opened Aug 05, 2014 by Kálmán Viktor@kviktor 
  • Report abuse
Report abuse

Feature better VM list

Closes #232 (closed)

  • Discussion 6
  • Commits 4
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on an old version of the diff Aug 06, 2014
    circle/dashboard/forms.py
    40 40 from django.template import Context
    41 41 from django.template.loader import render_to_string
    42 42 from django.utils.translation import ugettext as _
    43 from django.utils.translation import ugettext_lazy
    • Őry Máté @orymate commented Aug 06, 2014
      Owner

      from django.utils.translation import ugettext_lazy as _, the other one (ugettext()) is useless here fixd

      Edited Aug 06, 2014
      ~~`from django.utils.translation import ugettext_lazy as _`, the other one (ugettext()) is useless here~~ fixd
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Aug 06, 2014
    circle/dashboard/templates/dashboard/vm-list.html
    27 32 <p>
    28 33 <strong>{% trans "Group actions" %}</strong>
    29 34 <button id="vm-list-group-select-all" class="btn btn-info btn-xs">{% trans "Select all" %}</button>
    30 <a class="btn btn-default btn-xs" id="vm-list-group-migrate" disabled><i class="fa fa-truck"></i> {% trans "Migrate" %}</a>
    31 <a disabled href="#" class="btn btn-default btn-xs"><i class="fa fa-refresh"></i> {% trans "Reboot" %}</a>
    32 <a disabled href="#" class="btn btn-default btn-xs"><i class="fa fa-off"></i> {% trans "Shutdown" %}</a>
    33 <a id="vm-list-group-delete" disabled href="#" class="btn btn-danger btn-xs"><i class="fa fa-times"></i> {% trans "Destroy" %}</a>
    35 <a href="#" class="btn btn-default btn-xs" title="{% trans "Migrate" %}" disabled>
    • Őry Máté @orymate commented Aug 06, 2014
      Owner

      why not hide/remove them? fixd

      Edited Aug 06, 2014
      ~~why not hide/remove them?~~ fixd
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Aug 06, 2014
    circle/dashboard/forms.py
    1129 1130 class Meta:
    1130 1131 model = Instance
    1131 1132 fields = ('num_cores', 'priority', 'ram_size', )
    1133
    1134
    1135 vm_search_choices = (
    1136 (0, _("owned")),
    1137 (1, _("shared")),
    1138 (2, _("all")),
    1139 )
    1140
    1141
    1142 class VmListSearchForm(forms.Form):
    1143 s = forms.CharField(widget=forms.TextInput(attrs={
    • Őry Máté @orymate commented Aug 06, 2014
      Owner

      is this a required field? I would add a short summary about conditions format.

      Edited Aug 06, 2014
      is this a required field? I would add a short summary about conditions format.
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Aug 06, 2014
    circle/dashboard/static/dashboard/dashboard.js
    264 264 window.location.href = "/dashboard/vm/" + search_result[0].pk + "/";
    265 265 }
    266 266 if(e.keyCode == 13 && search_result.length > 1 && input.length > 0) {
    267 window.location.href = "/dashboard/vm/list/?s=" + input;
    267 window.location.href = "/dashboard/vm/list/?s=" + input + "&stype=2";
    • Őry Máté @orymate commented Aug 06, 2014
      Owner

      what's wrong with submitting the form (the default action)? input shoud be urlencoded this way. fixd

      Edited Aug 06, 2014
      ~~what's wrong with submitting the form (the default action)? `input` shoud be urlencoded this way.~~ fixd
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Aug 06, 2014
    circle/dashboard/views.py
    1592 1596 **self.get_queryset_filters()).select_related('owner', 'node'
    1593 1597 ).distinct()
    1594 1598  
    1599 def create_default_queryset(self):
    1600 stype = self.request.GET.get("stype", "0")
    • Őry Máté @orymate commented Aug 06, 2014
      Owner

      why don't you use the Form? fixd

      Edited Aug 06, 2014
      ~~why don't you use the Form?~~ fixd
    Please register or sign in to reply
  • Őry Máté @orymate commented Aug 07, 2014
    Owner

    +1 if all comments answered

    +1 if all comments answered
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Őry Máté
Assignee
Őry Máté @orymate
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!149