Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !206 opened Sep 22, 2014 by Bach Dániel@bachdaniel 
  • Report abuse
Report abuse

Fix Graphs

Closes #238 (closed) Closes #237 (closed) Closes #281 (closed)

Demo: https://miskolc.cloud.bme.hu:18525/dashboard/node/list/

  • Discussion 2
  • Commits 16
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on the diff Sep 23, 2014
    circle/dashboard/views/util.py
    570 raise NotImplementedError("Subclass must implement abstract method")
    571
    572 def get_object(self, request, pk):
    573 instance = self.model.objects.get(id=pk)
    574 if not instance.has_level(request.user, 'user'):
    575 raise PermissionDenied()
    576 return instance
    538 class GraphMixin(object):
    539 graph_time_options = [
    540 {'time': "1h", 'name': _("1 hour")},
    541 {'time': "1d", 'name': _("1 day")},
    542 {'time': "1w", 'name': _("1 week")},
    543 {'time': "30d", 'name': _("1 month")},
    544 {'time': "26w", 'name': _("6 months")},
    545 ]
    546 default_graph_time = "6h"
    • Őry Máté @orymate commented Sep 23, 2014
      Owner

      why isn't this in the list and displayed concretely on the button?

      why isn't this in the list and displayed concretely on the button?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Sep 23, 2014
    circle/dashboard/views/graph.py
    40 graphview_cls.metrics[graph_name] = metric_cls
    41
    42
    43 class GraphViewBase(LoginRequiredMixin, View):
    44 def create_class(self, cls):
    45 return type(str(cls.__name__ + 'Metric'), (cls, self.base), {})
    46
    47 def get(self, request, pk, metric, time, *args, **kwargs):
    48 graphite_url = settings.GRAPHITE_URL
    49 if graphite_url is None:
    50 raise Http404()
    51
    52 try:
    53 metric = self.metrics[metric]
    54 except KeyError:
    55 raise SuspiciousOperation()
    • Őry Máté @orymate commented Sep 23, 2014
      Owner

      404?

      404?
    Please register or sign in to reply
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Bach Dániel
Assignee
Bach Dániel @bachdaniel
Assign to
September
Milestone
September
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!206