Skip to content

CIRCLE / cloud

Go to a project
Merge request !256 opened by  

Feature port operations

👌

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Bach Dániel @bachdaniel

    Added 3 new commits:

    • d0cc86ea - vm: add add_port, remove_port to merged_activities.whitelist
    • 7f80408e - dashboard: add remove_port template
    • bef94b77 - dashboard: random fixes

    Added 3 new commits:

    • d0cc86ea - vm: add add_port, remove_port to merged_activities.whitelist
    • 7f80408e - dashboard: add remove_port template
    • bef94b77 - dashboard: random fixes
    Toggle commit list
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    606 606  
    607 607  
    608 608 @register_operation
    609 class RemovePortOperation(InstanceOperation):
    610 id = 'remove_port'
    611 name = _("close port")
    612 description = _("Close the specified port.")
    613 concurrency_check = False
    614 required_perms = ('vm.config_ports', )
    615 accept_states = ()
    • Őry Máté @orymate commented
      Owner

      None is the inherited default value, this is even suggesting that no states are acceptable (but of course evaluates to False, so the check isn't used).

      Edited
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    619 if interface.instance != self.instance:
    620 raise PermissionDenied()
    621 activity.readable_name = create_readable(
    622 ugettext_noop("close %(proto)s/%(port)d on %(host)s"),
    623 proto=rule.proto, port=rule.dport, host=rule.host)
    624 rule.delete()
    625
    626
    627 @register_operation
    628 class AddPortOperation(InstanceOperation):
    629 id = 'add_port'
    630 name = _("open port")
    631 description = _("Open the specified port.")
    632 concurrency_check = False
    633 required_perms = ('vm.config_ports', )
    634 accept_states = ()
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff
    circle/vm/operations.py
    606 606  
    607 607  
    608 608 @register_operation
    609 class RemovePortOperation(InstanceOperation):
    610 id = 'remove_port'
    611 name = _("close port")
    612 description = _("Close the specified port.")
    613 concurrency_check = False
    614 required_perms = ('vm.config_ports', )
    615 accept_states = ()
    616
    617 def _operation(self, activity, rule):
    618 interface = rule.host.interface_set.get()
    619 if interface.instance != self.instance:
    620 raise PermissionDenied()
    Please register or sign in to reply
  • Őry Máté @orymate commented
    Owner

    +1

  • Bach Dániel @bachdaniel

    Added 49 new commits:

    • 36b2d201 - dashboard: make group detail html nicer
    • 4e3677ed - dashboard: fix group detail js functions
    • ced57b53 - dashboard: make group list prettier
    • 13ef826b - update PO templates
    • fb838841 - vm: recreate interfaces from template in recovery operation
    • f03b1685 - locale: update Hungarian translation
    • 90423956 - node: add driver_version property
    • 522cd6dc - dashboard: show vmdriver version
    • 9efafced - dashboard: fix xss
    • 5eba485c - dashboard: escape html/or use .text instead of .html where needed
    • ae2e57a2 - dashboard: remove unused node list js
    • 5c71b275 - dashboard: check if vm has agent installed for pw reset
    • 7c604358 - vm: handle cleanup errors in SaveAsTemplateOperation
    • 3d81d408 - Merge branch 'fix-group-detail' into 'master'
    • e00127f9 - Merge branch 'issue-319v2'
    • 3c8b525a - node: add view_statistics permission
    • 9ee92053 - views/node: allow list with vm.view_statistics perms
    • 30681e63 - views/node: allow node box with vm.view_statistics perms
    • 9928686b - views/graph: allow graph with vm.view_statistics perms
    • f0c59231 - templates: allow node box with vm.view_statistics perms
    • 80178219 - tempaltes: hide new button index/node_box
    • f1016e28 - tempaltes: hide buttons to non superusers
    • b549f6b4 - templates: remove unnecessary buttons and forms
    • 8316fe03 - retab
    • 215b6f56 - dashboard: replace tabs in templates
    • 69cf4530 - views/node: add get function to properly return 403 on unathorized
    • 5c4c6d14 - tests: fix redirects to permission denied (403)
    • 32e17050 - dashboard: retab v2
    • d0f4347b - Merge branch 'feature-remove-tabs' into 'master'
    • 76d043aa - dashboard: retab v3
    • 387eb4e8 - Merge branch 'feature-node-permissions' into 'master'
    • e6dda2de - circle: add rosetta
    • f5a446ed - Merge branch 'feature-rosetta' into 'master'
    • fa12edb4 - dashboard: move TransferOwnership views to utils.py
    • 2ba3690e - dashboard: display full name
    • 15739763 - dashboard: add transfer template ownership views
    • 3118c6d8 - Merge branch 'issue-335' into 'master'
    • 0a31aaab - dashboard: remove tabs
    • 53d054a1 - Merge branch 'feature-show-version' into 'master'
    • cfb90704 - dashboard: fix indentation
    • 392da873 - vm: handle node.driver_version errors
    • b8cd2d07 - vm: add missing node.get_info calls
    • 4392ed39 - Merge branch 'node-fixes' into 'master'
    • af0882f5 - Merge branch 'feature-improved-recovery' into 'master'
    • 66afc59c - dashboard: add profile links
    • 833d5490 - Merge branch 'feature-tx-tpl-ownership' into 'master'
    • f6861f2b - vm: raise SuspiciousOperation instead of PermissionDenied
    • c4872897 - vm: remove accept_states lines
    • fc553851 - Merge remote-tracking branch 'origin/master' into feature-port-operations

    Added 49 new commits:

    • 36b2d201 - dashboard: make group detail html nicer
    • 4e3677ed - dashboard: fix group detail js functions
    • ced57b53 - dashboard: make group list prettier
    • 13ef826b - update PO templates
    • fb838841 - vm: recreate interfaces from template in recovery operation
    • f03b1685 - locale: update Hungarian translation
    • 90423956 - node: add driver_version property
    • 522cd6dc - dashboard: show vmdriver version
    • 9efafced - dashboard: fix xss
    • 5eba485c - dashboard: escape html/or use .text instead of .html where needed
    • ae2e57a2 - dashboard: remove unused node list js
    • 5c71b275 - dashboard: check if vm has agent installed for pw reset
    • 7c604358 - vm: handle cleanup errors in SaveAsTemplateOperation
    • 3d81d408 - Merge branch 'fix-group-detail' into 'master'
    • e00127f9 - Merge branch 'issue-319v2'
    • 3c8b525a - node: add view_statistics permission
    • 9ee92053 - views/node: allow list with vm.view_statistics perms
    • 30681e63 - views/node: allow node box with vm.view_statistics perms
    • 9928686b - views/graph: allow graph with vm.view_statistics perms
    • f0c59231 - templates: allow node box with vm.view_statistics perms
    • 80178219 - tempaltes: hide new button index/node_box
    • f1016e28 - tempaltes: hide buttons to non superusers
    • b549f6b4 - templates: remove unnecessary buttons and forms
    • 8316fe03 - retab
    • 215b6f56 - dashboard: replace tabs in templates
    • 69cf4530 - views/node: add get function to properly return 403 on unathorized
    • 5c4c6d14 - tests: fix redirects to permission denied (403)
    • 32e17050 - dashboard: retab v2
    • d0f4347b - Merge branch 'feature-remove-tabs' into 'master'
    • 76d043aa - dashboard: retab v3
    • 387eb4e8 - Merge branch 'feature-node-permissions' into 'master'
    • e6dda2de - circle: add rosetta
    • f5a446ed - Merge branch 'feature-rosetta' into 'master'
    • fa12edb4 - dashboard: move TransferOwnership views to utils.py
    • 2ba3690e - dashboard: display full name
    • 15739763 - dashboard: add transfer template ownership views
    • 3118c6d8 - Merge branch 'issue-335' into 'master'
    • 0a31aaab - dashboard: remove tabs
    • 53d054a1 - Merge branch 'feature-show-version' into 'master'
    • cfb90704 - dashboard: fix indentation
    • 392da873 - vm: handle node.driver_version errors
    • b8cd2d07 - vm: add missing node.get_info calls
    • 4392ed39 - Merge branch 'node-fixes' into 'master'
    • af0882f5 - Merge branch 'feature-improved-recovery' into 'master'
    • 66afc59c - dashboard: add profile links
    • 833d5490 - Merge branch 'feature-tx-tpl-ownership' into 'master'
    • f6861f2b - vm: raise SuspiciousOperation instead of PermissionDenied
    • c4872897 - vm: remove accept_states lines
    • fc553851 - Merge remote-tracking branch 'origin/master' into feature-port-operations
    Toggle commit list
  • Bach Dániel @bachdaniel

    mentioned in commit 72e1a7ba

    mentioned in commit 72e1a7ba

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment