Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !279 opened Nov 27, 2014 by Bach Dániel@bachdaniel 
  • Report abuse
Report abuse

Feature remove garbage 🚧

🚧

  • Discussion 8
  • Commits 22
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Nov 27, 2014
    Last updated by Bach Dániel Nov 27, 2014
    circle/dashboard/forms.py
    912 def __init__(self, *args, **kwargs):
    913 choices = kwargs.pop('choices')
    914 self.interface = kwargs.pop('default')
    915
    916 super(VmRemoveInterfaceForm, self).__init__(*args, **kwargs)
    917
    918 self.fields.insert(0, 'interface', forms.ModelChoiceField(
    919 queryset=choices, initial=self.interface, required=True,
    920 empty_label=None, label=_('Interface')))
    921 if self.interface:
    922 self.fields['interface'].widget = HiddenInput()
    923
    924 @property
    925 def helper(self):
    926 helper = super(VmRemoveInterfaceForm, self).helper
    927 print 'hi'
    • Kálmán Viktor @kviktor commented Nov 27, 2014
      Owner

      szia

      szia
    • Bach Dániel @bachdaniel commented Nov 27, 2014
      Owner

      😢

      :cry:
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Nov 27, 2014
    circle/dashboard/static/dashboard/dashboard.js
    3 3 var template = $(this).data("template");
    4 4 $.ajax({
    5 5 type: 'GET',
    6 url: '/dashboard/vm/create/' + (typeof template === "undefined" ? '' : '?template=' + template),
    6 url: $(this).prop('href') + (typeof template === "undefined" ? '' : '?template=' + template),
    • Kálmán Viktor @kviktor commented Nov 27, 2014
      Owner

      starting vm-s from template box doesn't work this way

      starting vm-s from template box doesn't work this way
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on the diff Nov 27, 2014
    circle/dashboard/static/dashboard/dashboard.js
    108 79 e.stopImmediatePropagation();
    109 80 return false;
    110 81 });
    111 $('body [title]:not(.title-favourite)').tooltip();
    82
    112 83 $('body .title-favourite').tooltip({'placement': 'right'});
    • Kálmán Viktor @kviktor commented Nov 27, 2014
      Owner

      These would be nicer as html attributes

      These would be nicer as html attributes
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on the diff Nov 27, 2014
    circle/dashboard/templates/dashboard/group-list/column-name.html
    7 7 <button type="submit" class="group-list-rename-submit btn btn-sm">{% trans "Rename" %}</button>
    8 8 </form>
    9 9 </div>
    10 <div id="group-list-column-name">
    10 <div class="group-list-column-name">
    • Kálmán Viktor @kviktor commented Nov 27, 2014
      Owner

      <div id="group-list-rename"> make this class too

      `<div id="group-list-rename">` make this class too
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Nov 27, 2014
    circle/dashboard/tests/test_views.py
    955 908 def test_unpermitted_group_page(self):
    956 909 c = Client()
    957 910 self.login(c, 'user1')
    911 groupnum = Group.objects.count()
    958 912 response = c.get('/dashboard/group/delete/' + str(self.g1.pk) + '/')
    959 self.assertEqual(response.status_code, 403)
    913 self.assertEqual(response.status_code, 302)
    914 self.assertEqual(Group.objects.count(), groupnum)
    • Kálmán Viktor @kviktor commented Nov 27, 2014
      Owner

      Seems unnecessary, GET will not delete anyways.

      Seems unnecessary, GET will not delete anyways.
    Please register or sign in to reply
  • Bach Dániel @bachdaniel

    Added 4 new commits:

    • 70debda7 - dashboard: remove unused code
    • d593d10c - dashboard: fix close modal btn
    • dae0a707 - dashboard: improve node detail
    • 6b11c860 - dashboard: move activity, operation js to activity.js
    Nov 27, 2014

    Added 4 new commits:

    • 70debda7 - dashboard: remove unused code
    • d593d10c - dashboard: fix close modal btn
    • dae0a707 - dashboard: improve node detail
    • 6b11c860 - dashboard: move activity, operation js to activity.js
    Added 4 new commits: * 70debda7d67 - dashboard: remove unused code * d593d10c807 - dashboard: fix close modal btn * dae0a707fe0 - dashboard: improve node detail * 6b11c8604eb - dashboard: move activity, operation js to activity.js
    Toggle commit list
  • Bach Dániel @bachdaniel

    Added 1 new commit:

    • b4596a86 - dashboard: remove print 'hi'
    Nov 28, 2014

    Added 1 new commit:

    • b4596a86 - dashboard: remove print 'hi'
    Added 1 new commit: * b4596a86075 - dashboard: remove print 'hi'
    Toggle commit list
  • Őry Máté
    @orymate started a discussion on an old version of the diff Nov 28, 2014
    circle/dashboard/static/dashboard/activity.js
    1 var in_progress = false;
    • Őry Máté @orymate commented Nov 28, 2014
      Owner

      why not in the closure?

      why not in the closure?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Nov 28, 2014
    circle/dashboard/views/node.py
    257 success_url = self.get_success_url()
    258 success_message = _("Node successfully deleted.")
    245 success_message = _("Node successfully deleted.")
    259 246  
    260 if request.is_ajax():
    261 if request.POST.get('redirect').lower() == "true":
    262 messages.success(request, success_message)
    263 return HttpResponse(
    264 json.dumps({'message': success_message}),
    265 content_type="application/json",
    266 )
    267 else:
    268 messages.success(request, success_message)
    269 return redirect(success_url)
    247 def check_auth(self):
    248 if not self.request.user.is_superuser:
    • Őry Máté @orymate commented Nov 28, 2014
      Owner

      why?

      why?
    Please register or sign in to reply
  • Bach Dániel @bachdaniel

    Added 6 new commits:

    • 7180bd8f - dashboard: fix forms
    • 77236999 - dashboard: remove unused renew template
    • c2a42986 - dashboard: move vlan perm check to Instance.create
    • cdac5b0e - dashboard: fix play button
    • 226d2b8d - dashboard: improve VmCreate view
    • 038f663e - dashboard: js fixes
    Dec 04, 2014

    Added 6 new commits:

    • 7180bd8f - dashboard: fix forms
    • 77236999 - dashboard: remove unused renew template
    • c2a42986 - dashboard: move vlan perm check to Instance.create
    • cdac5b0e - dashboard: fix play button
    • 226d2b8d - dashboard: improve VmCreate view
    • 038f663e - dashboard: js fixes
    Added 6 new commits: * 7180bd8ffb1 - dashboard: fix forms * 772369994cd - dashboard: remove unused renew template * c2a429867ff - dashboard: move vlan perm check to Instance.create * cdac5b0edc2 - dashboard: fix play button * 226d2b8d63c - dashboard: improve VmCreate view * 038f663e70d - dashboard: js fixes
    Toggle commit list
  • Bach Dániel @bachdaniel

    Added 1 new commit:

    • bbda4e9f47f - fix tests
    Dec 12, 2014

    Added 1 new commit:

    • bbda4e9f47f - fix tests
    Added 1 new commit: * bbda4e9f47f - fix tests
    Toggle commit list
  • Bach Dániel @bachdaniel

    Added 1 new commit:

    • 5f3e7e7b - fix tests
    Dec 12, 2014

    Added 1 new commit:

    • 5f3e7e7b - fix tests
    Added 1 new commit: * 5f3e7e7bc7b - fix tests
    Toggle commit list
  • Bach Dániel @bachdaniel

    Added 2 new commits:

    • 67622b86 - dashboard: move activity vars
    • f876f926 - dashboard: remove unnecessary perm check
    Jan 01, 2015

    Added 2 new commits:

    • 67622b86 - dashboard: move activity vars
    • f876f926 - dashboard: remove unnecessary perm check
    Added 2 new commits: * 67622b86f2e - dashboard: move activity vars * f876f926923 - dashboard: remove unnecessary perm check
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Bach Dániel
Assignee
Bach Dániel @bachdaniel
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: circle/cloud!279