Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !334 opened May 21, 2015 by Bach Dániel@bachdaniel 
  • Report abuse
Report abuse

Fix renew ✅

closes #375 (closed)

  • Discussion 2
  • Commits 1
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Guba Sándor
    @gubasandor started a discussion on the diff May 26, 2015
    circle/vm/operations.py
    978 if (not force and suspend and self.instance.time_of_suspend and
    979 suspend < self.instance.time_of_suspend):
    980 raise HumanReadableException.create(ugettext_noop(
    981 "Renewing the machine with the selected lease would result "
    982 "in its suspension time get earlier than before."))
    983 if (not force and delete and self.instance.time_of_delete and
    984 delete < self.instance.time_of_delete):
    985 raise HumanReadableException.create(ugettext_noop(
    986 "Renewing the machine with the selected lease would result "
    987 "in its delete time get earlier than before."))
    988 self.instance.time_of_suspend = suspend
    989 self.instance.time_of_delete = delete
    1000 try:
    1001 self.set_time_of_suspend(activity, suspend, force)
    1002 except:
    1003 pass
    • Guba Sándor @gubasandor commented May 26, 2015
      Owner

      except-pass?

      Edited May 28, 2015
      ~~except-pass~~?
    Please register or sign in to reply
  • Guba Sándor @gubasandor commented May 27, 2015
    Owner

    Catch only humanreadable 👍

    Catch only humanreadable :+1:
  • Bach Dániel @bachdaniel

    Added 1 commit:

    • 707287be - vm: fix #375 (closed) (Check suspend/delete time separately in renew)
    May 28, 2015

    Added 1 commit:

    • 707287be - vm: fix #375 (closed) (Check suspend/delete time separately in renew)
    Added 1 commit: * 707287be - vm: fix #375 (Check suspend/delete time separately in renew)
    Toggle commit list
  • Bach Dániel @bachdaniel

    mentioned in commit e5b9cb0f

    May 28, 2015

    mentioned in commit e5b9cb0f

    mentioned in commit e5b9cb0fee2475b8b48593b77caf7caf194fb9e8
    Toggle commit list
  • Bach Dániel @bachdaniel

    Status changed to merged

    May 28, 2015

    Status changed to merged

    Status changed to merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Bach Dániel
Assignee
Bach Dániel @bachdaniel
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!334