Skip to content

CIRCLE / cloud

Go to a project
Merge request !379 opened by  

Fix DataStore queries with get_default_datastore()

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Dudás Ádám
    @siliconbrain started a discussion on an old version of the diff
    circle/storage/models.py
    110 111 disks = Disk.objects.filter(destroyed__isnull=True, is_ready=True)
    111 112 return disks.exclude(filename__in=files)
    112 113  
    114 @classmethod
    115 def get_default_datastore(cls):
    116 try:
    117 datastore_name = settings.DEFAULT_DATASTORE
    118 if datastore_name:
    119 return cls.objects.get(name=datastore_name)
    120 except cls.DoesNotExist:
    121 pass
    122 return cls.objects.all()[0] # TODO
    • Dudás Ádám @siliconbrain commented
      Owner

      It was a feature that it raises an exception if there are more than 1 databases (or 0). This makes sense with ceph but not in the current version.

    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • f3ff40ed - storage: small rework on get_default_datastore()

    Added 1 commit:

    • f3ff40ed - storage: small rework on get_default_datastore()
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • d82f4c8f - dashboard: rename datastore in fixture

    Added 1 commit:

    • d82f4c8f - dashboard: rename datastore in fixture
    Toggle commit list
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff
    circle/storage/models.py
    110 111 disks = Disk.objects.filter(destroyed__isnull=True, is_ready=True)
    111 112 return disks.exclude(filename__in=files)
    112 113
    114 @classmethod
    115 def get_default_datastore(cls):
    116 datastore_name = settings.DEFAULT_DATASTORE
    117 if datastore_name:
    • Kálmán Viktor @kviktor commented
      Owner

      dataestore_name is present because of the default value, no need for the if

    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 092fffcf - storage: remove unecessary 'if' from get_default_datastore method

    Added 1 commit:

    • 092fffcf - storage: remove unecessary 'if' from get_default_datastore method
    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment