Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !389 opened Aug 18, 2016 by Czémán Arnold@cemiarni 
  • Report abuse
Report abuse

Rename operation

Issue: #392 (closed)

  • Discussion 3
  • Commits 5
  • Pipelines 4
  • Changes 7
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • fdf0285a - dashboard: remove unnecessary get_rename_operation() method
    Aug 29, 2016

    Added 1 commit:

    • fdf0285a - dashboard: remove unnecessary get_rename_operation() method
    Added 1 commit: * fdf0285a - dashboard: remove unnecessary get_rename_operation() method
    Toggle commit list
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Aug 31, 2016
    circle/dashboard/views/vm.py
    723 class VmRenameView(FormOperationMixin, VmOperationView):
    724 op = 'rename'
    725 icon = 'pencil'
    726 effect = 'success'
    727 show_in_toolbar = False
    728 form_class = VmRenameForm
    729
    730 def post(self, request, extra=None, *args, **kwargs):
    731 if extra is None:
    732 extra = {}
    733 form = self.form_class(self.request.POST, **self.get_form_kwargs())
    734 if form.is_valid():
    735 extra.update(form.cleaned_data)
    736 resp = super(FormOperationMixin, self).post(
    737 request, extra, *args, **kwargs)
    738 new_name = request.POST.get("new_name")
    • Kálmán Viktor @kviktor commented Aug 31, 2016
      Owner

      Use cleaned_data, it's cleaner (hehe).

      Use cleaned_data, it's cleaner (hehe).
    Please register or sign in to reply
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Aug 31, 2016
    circle/vm/operations.py
    1403 1403
    1404 1404
    1405 1405 @register_operation
    1406 class RenameOperation(InstanceOperation):
    1407 id = "rename"
    1408 name = _("rename")
    1409 description = _("Change the name of virtual machine.")
    1410 acl_level = "operator"
    1411 required_perms = ()
    1412
    1413 def _operation(self, user, activity, new_name):
    1414
    • Kálmán Viktor @kviktor commented Aug 31, 2016
      Owner

      no new new line

      no new new line
    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • e0f32040 - dashboard: fix VmRenameView
    Sep 12, 2016

    Added 1 commit:

    • e0f32040 - dashboard: fix VmRenameView
    Added 1 commit: * e0f32040 - dashboard: fix VmRenameView
    Toggle commit list
  • Kálmán Viktor @kviktor commented Oct 05, 2016
    Owner

    Renaming the VM stops the waiting for agent activity.

    Renaming the VM stops the waiting for agent activity.
  • Czémán Arnold @cemiarni

    merged

    Jul 07, 2017

    merged

    merged
    Toggle commit list
  • Czémán Arnold @cemiarni

    mentioned in commit 4565cf03

    Jul 07, 2017

    mentioned in commit 4565cf03

    mentioned in commit 4565cf039474f292717a9fc5022d261f487d097a
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
4
4 participants
Reference: circle/cloud!389
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.