Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !71 opened Apr 27, 2014 by Dudás Ádám@siliconbrain 
  • Report abuse
Report abuse

instance operations (add & remove) for disks #153

  • Discussion 4
  • Commits 4
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kálmán Viktor
    @kviktor started a discussion on commit 0ede81f1 Apr 26, 2014
    Last updated by Dudás Ádám Apr 27, 2014
    circle/dashboard/views.py
    2160 2160 disk = self.get_object()
    2161 2161 app = disk.get_appliance()
    2162 2162  
    2163 app.disks.remove(disk)
    2163 app.remove_disk(disk=disk, user=request.user)
    • Kálmán Viktor @kviktor commented Apr 26, 2014
      Owner

      get_appliance() can return an InstanceTemplate too which doesn't have that operation

      get_appliance() can return an InstanceTemplate too which doesn't have that operation
    • Dudás Ádám @siliconbrain commented Apr 27, 2014
      Owner

      fixed in 07190c6d

      fixed in 07190c6db
    Please register or sign in to reply
  • Dudás Ádám
    @siliconbrain started a discussion on commit 07190c6d Apr 27, 2014
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Apr 28, 2014
    circle/dashboard/views.py
    2160 2160 disk = self.get_object()
    2161 2161 app = disk.get_appliance()
    2162 2162  
    2163 app.disks.remove(disk)
    2163 if isinstance(app, Instance):
    2164 app.remove_disk(disk=disk, user=request.user)
    2165 else: # isinstance(app, InstanceTemplate)
    • Őry Máté @orymate commented Apr 28, 2014
      Owner

      I would implement InstanceTemplate.remove_disk(self, disk, **kwargs) 1e35578f

      Edited Apr 28, 2014
      ~~I would implement InstanceTemplate.remove_disk(self, disk, **kwargs)~~ 1e35578fa
    Please register or sign in to reply
  • Őry Máté @orymate commented Apr 28, 2014
    Owner

    +1

    +1
  • Őry Máté
    @orymate started a discussion on commit 1e35578f Apr 28, 2014
    • Őry Máté @orymate

      mentioned in merge request !71 (merged)

      Apr 28, 2014

      mentioned in merge request !71 (merged)

      mentioned in merge request !71
      Toggle commit list
    Please register or sign in to reply
  • Őry Máté @orymate

    mentioned in issue #153 (closed)

    Apr 29, 2014

    mentioned in issue #153 (closed)

    mentioned in issue #153
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!71