Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !8 opened Feb 21, 2014 by Oláh István Gergely@ogergo 
  • Report abuse
Report abuse

Feature Node Traits

  • Discussion 10
  • Commits 16
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Őry Máté
    @orymate started a discussion on an old version of the diff Feb 23, 2014
    Last updated by Oláh István Gergely Mar 12, 2014
    circle/dashboard/templates/dashboard/node-detail-home.html
    6 7 <dt>Description:</dt>
    7 8 <dd><small>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Nunc est libero, hendrerit at posuere sed, molestie congue quam. </small></dd>
    8 9 </dl>
    10 <div style="font-weight: bold;">{% trans "Traits" %}</div>
    11 <div id="node-details-traits" style="margin-bottom: 20px;">
    12 <div id="node-details-traits-list">
    13 {% if node.traits.all %}
    14 {% for t in node.traits.all %}
    15 <div class="label label-success label-tag" style="display: inline-block">
    16 {{ t }}
    17 <a data-trait-pk="{{ t.pk }}" href="#" class="node-details-remove-trait"><i class="icon-remove"></i></a>
    18 </div>
    19 {% endfor %}
    20 {% else %}
    21 <small>No trait added!</small>
    • Őry Máté @orymate commented Feb 23, 2014
      Owner

      {%trans%}

      `{%trans%}`
    • Oláh István Gergely @ogergo commented Mar 12, 2014
      Developer

      fixed.

      fixed.
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on the diff Feb 23, 2014
    circle/dashboard/views.py
    528 kwargs={'pk': self.object.pk}))
    529
    530 def __remove_trait(self, request):
    531 try:
    532 to_remove = request.POST.get('to_remove')
    533 self.object = self.get_object()
    534 self.object.traits.remove(to_remove)
    535 message = u"Success"
    536 except: # note this won't really happen
    537 message = u"Not success"
    538
    539 if request.is_ajax():
    540 return HttpResponse(
    541 json.dumps({'message': message}),
    542 content_type="application=json"
    543 )
    • Őry Máté @orymate commented Feb 23, 2014
      Owner

      else?

      else?
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Feb 23, 2014
    Last updated by Oláh István Gergely Mar 13, 2014
    circle/dashboard/views.py
    500 508 return redirect(reverse_lazy("dashboard.views.node-detail",
    501 509 kwargs={'pk': self.object.pk}))
    502 510  
    511 def __add_trait(self, request):
    512 new_trait_name = request.POST.get('new_trait')
    513 self.object = self.get_object()
    514
    515 if len(new_trait_name) < 1:
    516 message = u"Please input something!"
    • Őry Máté @orymate commented Feb 23, 2014
      Owner

      gettext?

      gettext?
    • Oláh István Gergely @ogergo commented Mar 13, 2014
      Developer

      solved with form.

      solved with form.
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Feb 23, 2014
    Last updated by Oláh István Gergely Mar 13, 2014
    circle/dashboard/views.py
    500 508 return redirect(reverse_lazy("dashboard.views.node-detail",
    501 509 kwargs={'pk': self.object.pk}))
    502 510  
    511 def __add_trait(self, request):
    512 new_trait_name = request.POST.get('new_trait')
    513 self.object = self.get_object()
    514
    515 if len(new_trait_name) < 1:
    516 message = u"Please input something!"
    517 elif len(new_trait_name) > 20:
    518 message = u"Trait name is too long!"
    • Őry Máté @orymate commented Feb 23, 2014
      Owner

      Form would be easier for validating this.

      Form would be easier for validating this.
    • Oláh István Gergely @ogergo commented Mar 13, 2014
      Developer

      fixed.

      fixed.
    Please register or sign in to reply
  • Őry Máté
    @orymate started a discussion on an old version of the diff Feb 23, 2014
    Last updated by Oláh István Gergely Mar 13, 2014
    circle/dashboard/views.py
    512 new_trait_name = request.POST.get('new_trait')
    513 self.object = self.get_object()
    514
    515 if len(new_trait_name) < 1:
    516 message = u"Please input something!"
    517 elif len(new_trait_name) > 20:
    518 message = u"Trait name is too long!"
    519 else:
    520 self.object.traits.create(name=new_trait_name)
    521
    522 try:
    523 messages.error(request, message)
    524 except:
    525 pass
    526
    527 return redirect(reverse_lazy("dashboard.views.node-detail",
    • Őry Máté @orymate commented Feb 23, 2014
      Owner

      get_absolute_url?

      get_absolute_url?
    • Oláh István Gergely @ogergo commented Mar 13, 2014
      Developer

      fixed.

      fixed.
    Please register or sign in to reply
  • Őry Máté @orymate commented Mar 13, 2014
    Owner

    Regression in merge: removing traits doesn't work.

    Regression in merge: removing traits doesn't work.
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
Pilot deploy
Milestone
Pilot deploy
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/cloud!8