Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / fwdriver

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 0
  • Merge Requests 1
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge request !3 opened Jul 29, 2015 by Czémán Arnold@cemiarni 
  • Report abuse
Report abuse

Systemd feature

Add systemd units and systemd detector.

  • Discussion 3
  • Commits 7
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Jul 29, 2015
    utils.py
    60 61 else:
    61 62 return sudo(('/sbin/ip', 'netns', 'exec',
    62 63 NETNS) + args, stdin)
    64
    65
    66 def is_there_systemd():
    67
    68 devnull = open(os.devnull, "w")
    • Kálmán Viktor @kviktor commented Jul 29, 2015
      Owner

      with open

      Edited Jul 29, 2015
      `with` open
    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 65e5a910 - is_there_systemd() with with
    Jul 30, 2015

    Added 1 commit:

    • 65e5a910 - is_there_systemd() with with
    Added 1 commit: * 65e5a910 - is_there_systemd() with with
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 19544e52 - prettify fw.py
    Jul 30, 2015

    Added 1 commit:

    • 19544e52 - prettify fw.py
    Added 1 commit: * 19544e52 - prettify fw.py
    Toggle commit list
  • Őry Máté
    @orymate started a discussion on an old version of the diff Jul 30, 2015
    utils.py
    60 61 else:
    61 62 return sudo(('/sbin/ip', 'netns', 'exec',
    62 63 NETNS) + args, stdin)
    64
    65
    66 def is_there_systemd():
    67
    68 with open(os.devnull, "w") as devnull:
    69
    70 try:
    71 sp.call(["/bin/systemctl", "--version"], stdout=devnull, stderr=devnull)
    • Őry Máté @orymate commented Jul 30, 2015
      Owner

      i would prefer just checking if this is an executable. it seems quite pointless (and ineffective) to execute it to check if it's working. or do we know about cases when the file exists but this call would throw an OSError?

      i would prefer just checking if this is an executable. it seems quite pointless (and ineffective) to execute it to check if it's working. or do we know about cases when the file exists but this call would throw an OSError?
    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • c89adcec - Make shorter is_there_systemd()
    Jul 30, 2015

    Added 1 commit:

    • c89adcec - Make shorter is_there_systemd()
    Added 1 commit: * c89adcec - Make shorter is_there_systemd()
    Toggle commit list
  • Bach Dániel @bachdaniel commented Aug 03, 2015
    Owner

    👍

    :+1:
  • Kálmán Viktor @kviktor

    mentioned in commit 41f5615a

    Aug 04, 2015

    mentioned in commit 41f5615a

    mentioned in commit 41f5615a973513be7ca8c729bd2e77c75429890b
    Toggle commit list
  • Kálmán Viktor @kviktor

    Status changed to merged

    Aug 04, 2015

    Status changed to merged

    Status changed to merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Kálmán Viktor
Assignee
Kálmán Viktor @kviktor
Assign to
None
Milestone
None
Assign milestone
Time tracking
4
4 participants
Reference: circle/fwdriver!3