Snapshot operations
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
-
disk.py287 def common_snapshot_operation(self, cmdline): 288 # Check if file already exists 289 if not os.path.isfile(self.get_path()): 290 raise Exception('Image does not exists: %s' % self.get_path()) 291 # Build list of Strings as command parameters 292 if self.format == 'iso' or self.format == 'raw': 293 raise NotImplemented() 294 else: 295 # Call subprocess 296 try: 297 return subprocess.check_output(cmdline) 298 except subprocess.CalledProcessError as e: 299 logger.error(e) 300 raise Exception(unicode(e)) 301 302 def snapshot(self, snapshot_name): -
Owner
def create_snapshot?
-
-
disk.py
284 284 logger.info("Extracting %s failed, keeping original.", 285 285 disk_path) 286 286 287 def snapshot(self): 287 def common_snapshot_operation(self, cmdline): 288 # Check if file already exists 289 if not os.path.isfile(self.get_path()): 290 raise Exception('Image does not exists: %s' % self.get_path()) 291 # Build list of Strings as command parameters 292 if self.format == 'iso' or self.format == 'raw': 293 raise NotImplemented() 294 else: -
Owner
it's cleaner without the else's indentation imho
-
-
disk.py
284 284 logger.info("Extracting %s failed, keeping original.", 285 285 disk_path) 286 286 287 def snapshot(self): 287 def common_snapshot_operation(self, cmdline): 288 # Check if file already exists 289 if not os.path.isfile(self.get_path()): 290 raise Exception('Image does not exists: %s' % self.get_path()) 291 # Build list of Strings as command parameters 292 if self.format == 'iso' or self.format == 'raw': 293 raise NotImplemented() 294 else: 295 # Call subprocess -
Owner
these type of comments are not useful
-
-
disk.py
284 284 logger.info("Extracting %s failed, keeping original.", 285 285 disk_path) 286 286 287 def snapshot(self): 287 def common_snapshot_operation(self, cmdline): 288 # Check if file already exists 289 if not os.path.isfile(self.get_path()): 290 raise Exception('Image does not exists: %s' % self.get_path()) 291 # Build list of Strings as command parameters -
Owner
copypaste?:D
-
