Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / storagedriver

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 2
  • Merge Requests 4
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Commits
  • Issue Boards
Merged
Merge request !5 opened Sep 24, 2014 by Guba Sándor@gubasandor 
  • Report abuse
Report abuse

Feature Save As Status

  • Discussion 6
  • Commits 1
  • Changes
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Bach Dániel
    @bachdaniel started a discussion on the diff Sep 24, 2014
    Last updated by Guba Sándor Sep 24, 2014
    disk.py
    88 89 format = disk_info.get('format')
    89 90 size = disk_info.get('virtual-size')
    90 91 actual_size = disk_info.get('actual-size')
    91 base_name = disk_info.get('backing-filename')
    92 # Check if disk has base (backing-image)
    93 base_path = disk_info.get('backing-filename')
    94 if base_path:
    95 base_name = os.path.basename(base_path)
    96 else:
    97 base_name = None
    98 # Based on backing image determine weather snapshot ot normal image
    • Bach Dániel @bachdaniel commented Sep 24, 2014
      Owner

      ☁ ☀ 🌁 ❄

      Edited Sep 24, 2014
      :cloud: :sunny: :foggy: :snowflake:
    • Guba Sándor @gubasandor commented Sep 24, 2014
      Owner

      🔢

      :1234:
    Please register or sign in to reply
  • Bach Dániel
    @bachdaniel started a discussion on the diff Sep 24, 2014
    Last updated by Guba Sándor Sep 24, 2014
    disk.py
    88 89 format = disk_info.get('format')
    89 90 size = disk_info.get('virtual-size')
    90 91 actual_size = disk_info.get('actual-size')
    91 base_name = disk_info.get('backing-filename')
    92 # Check if disk has base (backing-image)
    93 base_path = disk_info.get('backing-filename')
    94 if base_path:
    • Bach Dániel @bachdaniel commented Sep 24, 2014
      Owner

      are these conditionals required?

      are these conditionals required?
    • Guba Sándor @gubasandor commented Sep 24, 2014
      Owner

      yes

      yes
    Please register or sign in to reply
  • Bach Dániel
    @bachdaniel started a discussion on the diff Sep 24, 2014
    disk.py
    281 percent = new_percent
    282 if not task.is_aborted():
    283 task.update_state(
    284 task_id=parent_id,
    285 state=task.AsyncResult(parent_id).state,
    286 meta={'size': actsize, 'percent': percent})
    287 else:
    288 logger.warning(
    289 "Merging new disk %s is aborted by user.",
    290 new_disk.get_path())
    291 raise AbortException()
    267 292 sleep(1)
    268 293 except AbortException:
    269 294 proc.terminate()
    270 logger.warning("Aborted remove %s", new_disk.get_path())
    295 logger.warning("Aborted merge job removing %s",
    • Bach Dániel @bachdaniel commented Sep 24, 2014
      Owner

      removing is aborted?

      removing is aborted?
    Please register or sign in to reply
  • Bach Dániel @bachdaniel commented Sep 24, 2014
    Owner

    +1

    +1
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
2
2 participants
Reference: circle/storagedriver!5