Skip to content

CIRCLE / cloud

Go to a project
Merge request !366 opened by  

Send a notification when an activity has finished and the window not in focus

Issue: #444 (closed)

{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • cf9e0077 - dashboard: send a notification when an activity has finished and the window not in focus

    Added 1 commit:

    • cf9e0077 - dashboard: send a notification when an activity has finished and the window not in focus
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 9012bf31 - dashboard: improve and make switchable desktop notifications

    Added 1 commit:

    • 9012bf31 - dashboard: improve and make switchable desktop notifications
    Toggle commit list
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff
    circle/dashboard/templates/dashboard/_display-name.html
    15 15 {% endif %}
    16 16 {% endif %}
    17 17  
    18 <span id="user-options" data-desktop_notifications="{{ user.profile.desktop_notifications }}"><span>
    • Kálmán Viktor @kviktor commented
      Owner

      Add this to the top bar, _display-name is used in a lot of places with a lot of different users, not just the currently logged in one.

    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 986c3ad7 - dashboard: small improvements on destktop notifications

    Added 1 commit:

    • 986c3ad7 - dashboard: small improvements on destktop notifications
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    Added 1 commit:

    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 606d4527 - dashboard: grammar correction

    Added 1 commit:

    • 606d4527 - dashboard: grammar correction
    Toggle commit list
  • Dudás Ádám
    @siliconbrain started a discussion on an old version of the diff
    circle/dashboard/static/dashboard/activity.js
    169 169 );
    170 170 } else {
    171 171 in_progress = false;
    172 if(windowHasFocus === false && userWantNotifications()){
    Please register or sign in to reply
  • Dudás Ádám @siliconbrain commented
    Owner

    usage of apostrophes (') and quotes (") in JS files is fuckinquite inconsistent

  • Czémán Arnold @cemiarni

    Added 1 commit:

    • b26bfcad - dashboard: change window focus detection method

    Added 1 commit:

    • b26bfcad - dashboard: change window focus detection method
    Toggle commit list
  • Dudás Ádám @siliconbrain

    mentioned in commit 59532809

    mentioned in commit 59532809

    Toggle commit list
  • Dudás Ádám @siliconbrain

    Status changed to merged

    Status changed to merged

    Toggle commit list
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment