Skip to content
  • P
    Projects
  • G
    Groups
  • S
    Snippets
  • Help

CIRCLE / cloud

  • This project
    • Loading...
  • Sign in
Go to a project
  • Project
  • Repository
  • Issues 94
  • Merge Requests 10
  • Pipelines
  • Wiki
  • Snippets
  • Members
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Merged
Merge request !366 opened Apr 15, 2016 by Kálmán Viktor@kviktor 
  • Report abuse
Report abuse

Send a notification when an activity has finished and the window not in focus

Issue: #444 (closed)

  • Discussion 3
  • Commits 6
  • Changes 6
{{ resolvedDiscussionCount }}/{{ discussionCount }} {{ resolvedCountText }} resolved
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • cf9e0077 - dashboard: send a notification when an activity has finished and the window not in focus
    Apr 15, 2016

    Added 1 commit:

    • cf9e0077 - dashboard: send a notification when an activity has finished and the window not in focus
    Added 1 commit: * cf9e0077 - dashboard: send a notification when an activity has finished and the window not in focus
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 9012bf31 - dashboard: improve and make switchable desktop notifications
    Apr 15, 2016

    Added 1 commit:

    • 9012bf31 - dashboard: improve and make switchable desktop notifications
    Added 1 commit: * 9012bf31 - dashboard: improve and make switchable desktop notifications
    Toggle commit list
  • Kálmán Viktor
    @kviktor started a discussion on an old version of the diff Apr 15, 2016
    circle/dashboard/templates/dashboard/_display-name.html
    15 15 {% endif %}
    16 16 {% endif %}
    17 17  
    18 <span id="user-options" data-desktop_notifications="{{ user.profile.desktop_notifications }}"><span>
    • Kálmán Viktor @kviktor commented Apr 15, 2016
      Owner

      Add this to the top bar, _display-name is used in a lot of places with a lot of different users, not just the currently logged in one.

      Add this to the top bar, _display-name is used in a lot of places with a lot of different users, not just the currently logged in one.
    Please register or sign in to reply
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 986c3ad7 - dashboard: small improvements on destktop notifications
    Apr 15, 2016

    Added 1 commit:

    • 986c3ad7 - dashboard: small improvements on destktop notifications
    Added 1 commit: * 986c3ad7 - dashboard: small improvements on destktop notifications
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • bc0bd870 - dashboard: reduce regex
    Apr 18, 2016

    Added 1 commit:

    • bc0bd870 - dashboard: reduce regex
    Added 1 commit: * bc0bd870 - dashboard: reduce regex
    Toggle commit list
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • 606d4527 - dashboard: grammar correction
    Apr 19, 2016

    Added 1 commit:

    • 606d4527 - dashboard: grammar correction
    Added 1 commit: * 606d4527 - dashboard: grammar correction
    Toggle commit list
  • Dudás Ádám
    @siliconbrain started a discussion on an old version of the diff Apr 22, 2016
    circle/dashboard/static/dashboard/activity.js
    169 169 );
    170 170 } else {
    171 171 in_progress = false;
    172 if(windowHasFocus === false && userWantNotifications()){
    • Dudás Ádám @siliconbrain commented Apr 22, 2016
      Owner

      document.hasFocus()?

      `document.hasFocus()`?
    Please register or sign in to reply
  • Dudás Ádám @siliconbrain commented Apr 22, 2016
    Owner

    usage of apostrophes (') and quotes (") in JS files is fuckinquite inconsistent

    usage of apostrophes (`'`) and quotes (`"`) in JS files is ~~fuckin~~quite inconsistent
  • Czémán Arnold @cemiarni

    Added 1 commit:

    • b26bfcad - dashboard: change window focus detection method
    Apr 22, 2016

    Added 1 commit:

    • b26bfcad - dashboard: change window focus detection method
    Added 1 commit: * b26bfcad - dashboard: change window focus detection method
    Toggle commit list
  • Dudás Ádám @siliconbrain

    mentioned in commit 59532809

    Apr 25, 2016

    mentioned in commit 59532809

    mentioned in commit 5953280969c0512ff9c23d256633d77fe897672c
    Toggle commit list
  • Dudás Ádám @siliconbrain

    Status changed to merged

    Apr 25, 2016

    Status changed to merged

    Status changed to merged
    Toggle commit list
  • Write
  • Preview
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View labels
3
3 participants
Reference: circle/cloud!366
×

Revert this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.
×

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.